Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this repo, a rate limiter class is implemented using the simple "Token Bucket Algorithm".
Then, in the ResourceController, a concurrentHashMap to hold a mapping between client's IP address and its own bucket(limiter). ConcurrentHasMap is used to ensure that the code is thread-safe.
With each successful request, client can see how many tokens are left in the header "X-Rate-Limit-Remaining".
When the client is rate-limited, the header includes "X-Rate-Limit-Retry-After-Seconds"
Unit tests were written.
Further improvements can be done in taken into consideration of using the functional endpoints provided by Spring Webflux.
And also, error handling haven't been added to the REST endpoint.