This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 404
124 apps as modules #349
Open
stian-johnsen
wants to merge
32
commits into
dev
Choose a base branch
from
124-apps-as-modules
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
124 apps as modules #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gregators into abstract image source, sink, and data-set partitioner classes with file and memory implementations
This has to be left to last as it involves a lot of file changes. Other PRs and issues must be resolved first. |
… into 124-apps-as-modules
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Testing
Description
This PR covers the changes proposed in tickets #346 and #124. It introduces a module wrapper allowing for the running of NiftyNet applications in 3rd-party code, and a set of changes that enable the input from and output to memory of images.
The code is known to work for segmentation and regression applications. However, the changes made to the GAN, classification, and registration applications have not been tested.
Types of changes
Impacted Areas in Application
List general components of the application that this PR will affect: