Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jiten: cherry-pick test fix from upstream #274349

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Conversation

IreneKnapp
Copy link
Contributor

Description of changes

The build of jiten is broken due to a test failure.

This fixes #271600 by cherry-picking an unreleased patch from upstream, as discussed on the issue thread.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Whovian9369
Copy link

Appears to build successfully on my end, also on x86_64-linux.

Copy link
Member

@obfusk obfusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the issue, I can't currently test the package myself, but since others have confirmed my patch seems to work correctly, this PR LGTM. Thanks!

@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 15, 2023
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 17, 2023
@ofborg ofborg bot requested a review from obfusk December 18, 2023 00:42
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 18, 2023
@pbsds
Copy link
Member

pbsds commented Dec 31, 2023

Result of nixpkgs-review pr 274349 run on x86_64-linux 1

2 packages built:
  • jiten
  • jiten.dist

Patch LGTM and tried jiten with --help and jmdict. Thanks you for the support from upstream!

@pbsds pbsds merged commit c87f08e into NixOS:master Dec 31, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: jiten
6 participants