Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.asteroid-filterbanks: fix tests #360116

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Nov 29, 2024

Things done

Work around the various failing tests.

cc @MatthewCroughan

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 360116


x86_64-linux

❌ 8 packages failed to build:
  • python311Packages.asteroid-filterbanks
  • python311Packages.asteroid-filterbanks.dist
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
  • python312Packages.pyannote-audio
  • python312Packages.pyannote-audio.dist
  • whisper-ctranslate2
  • whisper-ctranslate2.dist
✅ 2 packages built:
  • python312Packages.asteroid-filterbanks
  • python312Packages.asteroid-filterbanks.dist

aarch64-linux

❌ 10 packages failed to build:
  • python311Packages.asteroid-filterbanks
  • python311Packages.asteroid-filterbanks.dist
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
  • python312Packages.asteroid-filterbanks
  • python312Packages.asteroid-filterbanks.dist
  • python312Packages.pyannote-audio
  • python312Packages.pyannote-audio.dist
  • whisper-ctranslate2
  • whisper-ctranslate2.dist

x86_64-darwin

❌ 2 packages failed to build:
  • python311Packages.asteroid-filterbanks
  • python311Packages.asteroid-filterbanks.dist
✅ 2 packages built:
  • python312Packages.asteroid-filterbanks
  • python312Packages.asteroid-filterbanks.dist

aarch64-darwin

❌ 8 packages failed to build:
  • python311Packages.asteroid-filterbanks
  • python311Packages.asteroid-filterbanks.dist
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
  • python312Packages.pyannote-audio
  • python312Packages.pyannote-audio.dist
  • whisper-ctranslate2
  • whisper-ctranslate2.dist
✅ 2 packages built:
  • python312Packages.asteroid-filterbanks
  • python312Packages.asteroid-filterbanks.dist

@GaetanLepage GaetanLepage force-pushed the asteroid-filterbanks branch 5 times, most recently from 9e77bbe to 6b0fcba Compare November 29, 2024 13:36
@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 360116


x86_64-linux

✅ 10 packages built:
  • python311Packages.asteroid-filterbanks
  • python311Packages.asteroid-filterbanks.dist
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
  • python312Packages.asteroid-filterbanks
  • python312Packages.asteroid-filterbanks.dist
  • python312Packages.pyannote-audio
  • python312Packages.pyannote-audio.dist
  • whisper-ctranslate2
  • whisper-ctranslate2.dist

aarch64-linux

✅ 10 packages built:
  • python311Packages.asteroid-filterbanks
  • python311Packages.asteroid-filterbanks.dist
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
  • python312Packages.asteroid-filterbanks
  • python312Packages.asteroid-filterbanks.dist
  • python312Packages.pyannote-audio
  • python312Packages.pyannote-audio.dist
  • whisper-ctranslate2
  • whisper-ctranslate2.dist

x86_64-darwin

✅ 4 packages built:
  • python311Packages.asteroid-filterbanks
  • python311Packages.asteroid-filterbanks.dist
  • python312Packages.asteroid-filterbanks
  • python312Packages.asteroid-filterbanks.dist

aarch64-darwin

✅ 10 packages built:
  • python311Packages.asteroid-filterbanks
  • python311Packages.asteroid-filterbanks.dist
  • python311Packages.pyannote-audio
  • python311Packages.pyannote-audio.dist
  • python312Packages.asteroid-filterbanks
  • python312Packages.asteroid-filterbanks.dist
  • python312Packages.pyannote-audio
  • python312Packages.pyannote-audio.dist
  • whisper-ctranslate2
  • whisper-ctranslate2.dist

@mweinelt mweinelt merged commit eca5c98 into NixOS:master Nov 29, 2024
16 of 17 checks passed
@GaetanLepage GaetanLepage deleted the asteroid-filterbanks branch November 29, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants