Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustfmt-nightly: add -headerpad_max_install_names x64 darwin #369349

Merged

Conversation

paparodeo
Copy link
Contributor

fix failing install_name_tool not having enough space to write the path into the binary

error: install_name_tool: changing install names or rpaths can't be redone for: /nix/store/.../git-rustfmt (for architecture x86_64) because larger updated load commands do not fit (the program must be relinked, and you may need to use -headerpad or -headerpad_max_install_names)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

fix failing install_name_tool not having enough space to write the path
into the binary

> error: install_name_tool: changing install names or rpaths can't be redone for: /nix/store/.../git-rustfmt (for architecture x86_64) because larger updated load commands do not fit (the program must be relinked, and you may need to use -headerpad or -headerpad_max_install_names)
@nix-owners nix-owners bot requested review from figsoda, Mic92, winterqt and zowoq December 30, 2024 10:43
@vcunat vcunat merged commit 1d8eab1 into NixOS:staging-next-24.05 Dec 30, 2024
11 of 12 checks passed
@paparodeo paparodeo deleted the rustfmt-nightly-fix-install-name branch December 30, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants