refine: init at 0.4.0 #370574
Open
refine: init at 0.4.0 #370574
+100
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5042 |
getchoo
reviewed
Jan 4, 2025
getchoo
reviewed
Jan 5, 2025
getchoo
approved these changes
Jan 5, 2025
getchoo
added
the
12.approvals: 1
wegank
removed
the
12.approvals: 1
getchoo
requested changes
Jan 7, 2025
getchoo
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
I'd like to leave this open for a few days to get feedback on us vendoring libadwaita
Otherwise LGTM and works as expected
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 370574
x86_64-linux
✅ 1 package built:
- refine
getchoo
added
the
12.approvals: 1
wegank
removed
the
12.approvals: 1
getchoo
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Works as expected
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 370574
x86_64-linux
✅ 1 package built:
- refine
getchoo
added
the
12.approvals: 1
getchoo
approved these changes
Jan 8, 2025
wegank
removed
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak various aspects of GNOME. https://gitlab.gnome.org/TheEvilSkeleton/Refine
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.