Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.runstats: init at v2.0.0 #371277

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

python312Packages.runstats: init at v2.0.0 #371277

wants to merge 2 commits into from
+51 −0

Conversation

osbm
Copy link

@osbm osbm commented Jan 5, 2025

Things done

Added runstats python package and added myself as a maintainer.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jan 5, 2025
@osbm
Copy link
Author

osbm commented Jan 5, 2025

Related issue #371267 . This package is required by fastmri package

@nix-owners nix-owners bot requested a review from natsukium January 5, 2025 22:26
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jan 5, 2025
@lucasew
Copy link
Contributor

lucasew commented Jan 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371277

x86_64-linux

✅ 4 packages built:
  • python312Packages.runstats
  • python312Packages.runstats.dist
  • python313Packages.runstats
  • python313Packages.runstats.dist

@lucasew
Copy link
Contributor

lucasew commented Jan 6, 2025

Please split the commits in the following way:

  • one to add you to the maintainer list
  • one with the rest

@osbm
Copy link
Author

osbm commented Jan 6, 2025

I was having a pytest error and i fixed it with the last commit. I dont know how to split commits but now i will look into that.

@osbm osbm force-pushed the add-python-runstat branch from c887d8f to ca92596 Compare January 6, 2025 13:30
@osbm
Copy link
Author

osbm commented Jan 6, 2025

@lucasew Thank you so much for your help. I am pretty new to this and i am sorry if this bothered you. Can you check once more?

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 6, 2025
@lucasew
Copy link
Contributor

lucasew commented Jan 6, 2025

I was having a pytest error and i fixed it with the last commit. I dont know how to split commits but now i will look into that.

Search for git rebase --interactive to join, to split you can git reset --soft that will drop the commits but stage the changes then you redo the commits.

At the end you git push --force to update the commits here.

@lucasew
Copy link
Contributor

lucasew commented Jan 6, 2025

Diff LGTM

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 6, 2025
@osbm osbm force-pushed the add-python-runstat branch from 0b4d5d4 to 9f16d99 Compare January 6, 2025 13:50
@osbm
Copy link
Author

osbm commented Jan 6, 2025

Also now the default.nix file obeys nixfmt-rfc-style format. I recommitted the changes so there are stills 2 commits

@lucasew
Copy link
Contributor

lucasew commented Jan 6, 2025

Also now the default.nix file obeys nixfmt-rfc-style format. I recommitted the changes so there are stills 2 commits

Amount of the commits are ok, just the name is out of standard

  • First commit would be something like maintainers: add yourname
  • Second commit would be basically the same as the title of the PR, but without the v in the version.

@osbm osbm force-pushed the add-python-runstat branch from 9f16d99 to ca106c7 Compare January 6, 2025 14:13
@osbm osbm requested a review from lucasew January 6, 2025 14:31
@osbm
Copy link
Author

osbm commented Jan 7, 2025 •
edited
Loading

Does ofborg maintainer list checks usually take this long to start?

@lucasew
Copy link
Contributor

lucasew commented Jan 7, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371277

x86_64-linux

✅ 4 packages built:
  • python312Packages.runstats
  • python312Packages.runstats.dist
  • python313Packages.runstats
  • python313Packages.runstats.dist

@osbm osbm mentioned this pull request Jan 9, 2025
Draft
13 tasks
@osbm osbm force-pushed the add-python-runstat branch from ca106c7 to 4a6bc63 Compare January 10, 2025 17:10
@osbm osbm requested a review from eljamm January 10, 2025 17:13
@eljamm
Copy link
Contributor

eljamm commented Jan 10, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371277

x86_64-linux

✅ 4 packages built:
  • python312Packages.runstats
  • python312Packages.runstats.dist
  • python313Packages.runstats
  • python313Packages.runstats.dist

x86_64-darwin

✅ 4 packages built:
  • python312Packages.runstats
  • python312Packages.runstats.dist
  • python313Packages.runstats
  • python313Packages.runstats.dist

aarch64-darwin

✅ 4 packages built:
  • python312Packages.runstats
  • python312Packages.runstats.dist
  • python313Packages.runstats
  • python313Packages.runstats.dist

eljamm
eljamm approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks a lot and welcome to nixpkgs!

@eljamm eljamm added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eljamm eljamm eljamm approved these changes

@natsukium natsukium Awaiting requested review from natsukium

@lucasew lucasew Awaiting requested review from lucasew

Assignees
No one assigned
Labels
6.topic: python 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@osbm @lucasew @eljamm @NixOSInfra