Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hcdiag: init at 0.5.5 #371689

Merged
merged 1 commit into from
Jan 12, 2025
Merged

hcdiag: init at 0.5.5 #371689

merged 1 commit into from
Jan 12, 2025

Conversation

ethancedwards8
Copy link
Member

@ethancedwards8 ethancedwards8 commented Jan 7, 2025

Things done

Add package

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ethancedwards8
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371689


aarch64-darwin

✅ 1 package built:
  • hcdiag

@ethancedwards8
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371689


x86_64-linux

✅ 1 package built:
  • hcdiag

pkgs/by-name/hc/hcdiag/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/hc/hcdiag/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/hc/hcdiag/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/hc/hcdiag/package.nix Outdated Show resolved Hide resolved
@ethancedwards8 ethancedwards8 force-pushed the hcdiag branch 2 times, most recently from b3ccabc to 584f640 Compare January 12, 2025 17:07
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371689


x86_64-linux

✅ 1 package built:
  • hcdiag

aarch64-linux

✅ 1 package built:
  • hcdiag

x86_64-darwin

✅ 1 package built:
  • hcdiag

aarch64-darwin

✅ 1 package built:
  • hcdiag

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you :)

pkgs/by-name/hc/hcdiag/package.nix Outdated Show resolved Hide resolved
Signed-off-by: Ethan Carter Edwards <[email protected]>
@GaetanLepage GaetanLepage merged commit 549d2f5 into NixOS:master Jan 12, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants