Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintainers: add FKouhai #371900

Closed
wants to merge 1 commit into from
Closed

maintainers: add FKouhai #371900

wants to merge 1 commit into from

Conversation

FKouhai
Copy link

@FKouhai FKouhai commented Jan 7, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jan 7, 2025
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jan 7, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 7, 2025
@Shawn8901
Copy link
Contributor

Shawn8901 commented Jan 7, 2025

As i found as comment from drupol super nice formulated, i cite:

Hello,

Thank you for your request.

Could you please provide some context or motivation behind your request to be added to the maintainer list? It would be helpful for us to understand how this aligns with your intentions or contributions to the project.

In my opinion, it might be more effective to create a PR that demonstrates why being included in the maintainer list is relevant. For instance:

Are you planning to contribute to nixpkgs?
Do you intend to adopt and maintain specific packages?

If your goal is to adopt packages, there's no need for a separate PR for this request. Instead, you can include a commit in a PR where it's clear which packages you'd like to maintain.

Please note that this is not about discouraging new contributors, on the contrary! We value new maintainers, and some contextual information will help us streamline the process and support your contributions effectively.

Thank you.

So no need for a PR that just adds you to the maintainer list, just include that commit as first into the PR for the package/module that you like to contribute to or adopt.

@FKouhai
Copy link
Author

FKouhai commented Jan 7, 2025

@Shawn8901 oh, thanks for feedback, I thought I had to split my PR's, I have this PR as well for a new package(it isnt okay I still need to push some changes I thought I made)
#371906

@Shawn8901
Copy link
Contributor

No problem. Welcome on board!
Just cherry-pick this commit into your branch that inits the package, and re-order the commits (you can do that whilst rebasing), that should be okay then.
This PR you can close this PR after cherry-picking.

@FKouhai FKouhai closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants