Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xunlei-uos: init at 1.0.0.5 #372432

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

xunlei-uos: init at 1.0.0.5 #372432

wants to merge 2 commits into from
+179 −0

Conversation

LinuxWhatA
Copy link

@LinuxWhatA LinuxWhatA commented Jan 9, 2025 •
edited
Loading

xunlei downloader https://www.xunlei.com/

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jan 9, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 9, 2025
xiaoxiangmoe
xiaoxiangmoe reviewed Jan 9, 2025
View reviewed changes
pkgs/by-name/xu/xunlei-bin/package.nix Outdated
src =
{
x86_64-linux = fetchurl {
url = "https://com-store-packages.uniontech.com/appstore/pool/appstore/c/com.xunlei.download/com.xunlei.download_${version}_amd64.deb";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add passthru.updateScript for update this?
Otherwise other maintainers don't know how to get this link from Xunlei's official homepage https://www.xunlei.com .

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢反馈，这个链接来自 AUR 提供的源，我目前没有办法自动获取此链接，目前暂时需要手动前往 AUR 查看源，我将尝试与作者联系寻求方法。

DeepL translator: Thanks for the feedback, this link is from the source provided by AUR, I currently do not have a way to get this link automatically, for the time being I need to manually go to AUR to check the source, I will try to contact the author for a way to do this.

@LinuxWhatA
Copy link
Author

Okay

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jan 9, 2025
@LinuxWhatA LinuxWhatA force-pushed the xunlei-bin branch 2 times, most recently from ad7e120 to 92f45ac Compare January 9, 2025 19:15
@LinuxWhatA LinuxWhatA changed the title xunlei-bin: init at 1.0.0.5 xunlei: init at 1.0.0.5 Jan 10, 2025
@LinuxWhatA
Copy link
Author

请问我需要合并你的代码吗？还是说不做任何修改直接运行git push --force-with-lease？

DeepL: Do I need to merge your code? Or should I just run git push --force-with-lease without making any changes?

Screenshot_20250110_093752

xiaoxiangmoe
xiaoxiangmoe reviewed Jan 10, 2025
View reviewed changes
pkgs/by-name/xu/xunlei/package.nix Outdated
sources = import ./sources.nix;

xunlei = stdenv.mkDerivation rec {
pname = "xunlei";
Copy link
Contributor

@xiaoxiangmoe xiaoxiangmoe Jan 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package is not provided by official xunlei website, maybe you can add a -uos suffix, like wechat-uos

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, then I'll change it to xunlei-uos

@LinuxWhatA
Copy link
Author

I see, will test the proposed changes later and revise the commit to xunlei-uos.

@LinuxWhatA LinuxWhatA changed the title xunlei: init at 1.0.0.5 xunlei-uos: init at 1.0.0.5 Jan 10, 2025
@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aucub aucub aucub approved these changes

@xiaoxiangmoe xiaoxiangmoe xiaoxiangmoe approved these changes

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LinuxWhatA @xiaoxiangmoe @aucub @wegank @NixOSInfra