Skip to content

Commit

Permalink
Fix issues from refactoring
Browse files Browse the repository at this point in the history
- Remove method from pico executor which is handled in serial base
  executor
- Fix wrong variable used when auto connecting to serial device

Signed-off-by: Rune Haugaard <[email protected]>
  • Loading branch information
Noloxs committed Dec 18, 2024
1 parent 77d355a commit 71ec1e7
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
2 changes: 1 addition & 1 deletion src/executor/executer_base_serial.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def connect_to_device(self, port):

self.usb_device = serial.Serial(port.device, baudrate=115200, timeout=.1)
self.controller.update_executor_menu()
setattr(self.settings, KEY_LAST_CONNECTED_DEFAULT, str(port.vid) + "-" + str(port.pid))
setattr(self.settings, self.KEY_LAST_CONNECTED_DEVICE, str(port.vid) + "-" + str(port.pid))
self.controller.update_title_description("Connected to: " + port.name)

# TODO Send connection test message
Expand Down
4 changes: 0 additions & 4 deletions src/executor/executer_pico.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,6 @@ def prepare(self):
self.keyDelayJitter = getattr(self.settings, KEY_DELAY_JITTER, KEY_DELAY_JITTER_DEFAULT)
self.triggerDelay = getattr(self.settings, TRIGGER_DELAY, TRIGGER_DELAY_DEFAULT)
self.triggerDelayJitter = getattr(self.settings, TRIGGER_DELAY_JITTER, TRIGGER_DELAY_JITTER_DEFAULT)

def send_bytes(self, bytes):
if self.pico is not None:
self.pico.write(bytes)

def parse_macro_key(self, key):
if key in self.key_map:
Expand Down

0 comments on commit 71ec1e7

Please sign in to comment.