Minor settings cleanup #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On review, I found minor issues. a settings test did not run, and failed when activated. Fixed lead to clean-code based readability to settings constructor. Also change a settings reference to singleton use, rather than deep reference.
|
Merge if happy :) |
Noloxs
requested changes
May 28, 2024
src/classes/settings.py
Outdated
Comment on lines
28
to
29
| if not self.loadFromFile(): | ||
| self.loadDefaults() |
There was a problem hiding this comment.
This will cause a crash if the file loaded doesn't contain all the needed defaults.
So it is still much safer to load defaults and then overwrite them
Noloxs
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On review, I found minor issues. a settings test did not run, and failed when activated. Fixed lead to clean-code based readability to settings constructor. Also change a settings reference to singleton use, rather than deep reference.