Fix layout for main windows #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now get the item heights dynamically, and add appropriate padding.
Still not perfect, could use a -4/5 at to make the bottom border match. It might just be the 5 margin on the items that isn't applied if there is no item after it. resulting in a -5 Signed-off-by: Rune Haugaard <[email protected]>
|
I made some changes. Please give it a look @stixes |
Much improved! I like 👍 Merge if happy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now get the item heights dynamically, and add appropriate padding.
Faulty layout (notic scrollbar, and the cut off macro nr. 9):
Fixed version:
