task/Add scan for devices btn #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Noloxs
commented
Dec 18, 2024
Noloxs
commented
- Add scan for serial devices button
- Fix issues from refactoring
Add rescan button to allow for a user to attach a serial passthrough devices after boot. Extract serial base code and logic to a new serial base executor for arduino and pico executors to inherent from NB: Not test with devices as they were unavailable during testing Resolves: #61 Signed-off-by: Rune Haugaard <[email protected]>
- Remove method from pico executor which is handled in serial base executor - Fix wrong variable used when auto connecting to serial device Signed-off-by: Rune Haugaard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.