Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] l10n_be_cooperator_website_national_number #120

Merged
merged 34 commits into from
May 2, 2024
Merged

[16.0][MIG] l10n_be_cooperator_website_national_number #120

merged 34 commits into from
May 2, 2024

Conversation

victor-champonnois
Copy link
Member

@victor-champonnois victor-champonnois commented Mar 15, 2024 •
edited
Loading

internal task
depends (and currently based on) on #119

victor-champonnois and others added 30 commits March 15, 2024 13:59
@victor-champonnois
[ADD] l10n_be_cooperator_national_number
0531c6a 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@victor-champonnois
[ADD] l10n_be_cooperator_website_national_number
f77e653 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@victor-champonnois
run black
ad29dd2 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@victor-champonnois
[UPD] Update l10n_be_cooperator_national_number.pot
57ff13a 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@OCA-git-bot @victor-champonnois
[UPD] README.rst
5bde3f4 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@OCA-git-bot @victor-champonnois
[ADD] icon.png
9fd0aee 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca @victor-champonnois
[IMP] l10n_be_cooperator_national_number: black, isort, prettier
13f4361
@carmenbianca @victor-champonnois
[MIG] l10n_be_cooperator_national_number: Migration to 13.0
246ff01 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca @victor-champonnois
[MIG] l10n_be_cooperator_national_number: Migration to 14.0
a62e73e 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca @victor-champonnois
[FIX] l10n_be_cooperator_national_number: Stop using deprecated _comp…
3b21a3c 
…any_default_get()

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca @victor-champonnois
[REF] l10n_be_cooperator_national_number: Separate display from require
19f2de0 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca @victor-champonnois
[FIX] l10n_be_cooperator_national_number: Repair failing migration
b78317a 
In some scenarios, the migration is run on a database that does not yet
have the requisite fields in the database. By making it a post-migration
script, we avoid the problem.

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@huguesdk @victor-champonnois
[IMP] use double quotes in user-facing message
8f8fbfe
@carmenbianca @victor-champonnois
[FIX] l10n_be_cooperator_national_number: Don't write non-existent fi…
ec18fb5 
…eld to res.partner
@carmenbianca @victor-champonnois
[FIX] l10n_be_cooperator_national_number: Write national number even …
3e5ccb1 
…when not required
@carmenbianca @victor-champonnois
[FIX] l10n_be_cooperator_national_number: Fix the tests
9714f38
@victor-champonnois
[IMP] l10n_be_cooperator_national_number: black, isort, prettier
b710c95
@victor-champonnois
[MIG] l10n_be_cooperator_national_number: Migration to 15.0
b5de53a
@victor-champonnois
[MIG] l10n_be_cooperator_national_number: Migration to 16.0
56f29ab
@victor-champonnois
[REF] depends on l10n_be_partner_identification
39bdd4d 
rather than on l10n_be_national_number (in v14)
@victor-champonnois
[ADD] l10n_be_cooperator_website_national_number
e87778d 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@victor-champonnois
run black
6684026 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@victor-champonnois
[UPD] Update l10n_be_cooperator_website_national_number.pot
caf1ced 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@OCA-git-bot @victor-champonnois
[UPD] README.rst
ae3123e 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@OCA-git-bot @victor-champonnois
[ADD] icon.png
dda145f 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca @victor-champonnois
[IMP] l10n_be_cooperator_website_national_number: black, isort, prettier
181e6b3
@carmenbianca @victor-champonnois
[MIG] l10n_be_cooperator_website_national_number: Migration to 13.0
3a5470f 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca @victor-champonnois
[MIG] l10n_be_cooperator_website_national_number: Migration to 14.0
95f1c72 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca @victor-champonnois
[FIX] l10n_be_cooperator_website_national_number: Remove deprecated m…
33362e4 
…ethod call

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@victor-champonnois
[IMP] l10n_be_cooperator_website_national_number: black, isort, prettier
6cbe2ad
@victor-champonnois victor-champonnois force-pushed the 16.0-mig-l10n_be_cooperator_website_national_number branch from 91526af to 82c85cf Compare March 15, 2024 13:52
@victor-champonnois victor-champonnois force-pushed the 16.0-mig-l10n_be_cooperator_website_national_number branch from 82c85cf to bbf5ca1 Compare March 15, 2024 14:18
polchampion
polchampion approved these changes Mar 22, 2024
View reviewed changes
Copy link

@polchampion polchampion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successful functional test

Note that since the check on the Belgian national number is enforced upon validation, it is possible to submit the request form with an invalid national number.

@polchampion
Copy link

@carmenbianca same here

@carmenbianca
[FIX] l10n_be_cooperator_website_national_number: Expand roadmap
16ccf39 
Comment by Pol Champion.

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
carmenbianca
carmenbianca approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@carmenbianca carmenbianca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small update to the roadmap with @polchampion 's comment

@carmenbianca
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-120-by-carmenbianca-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 29, 2024
@OCA-git-bot
Merge PR #120 into 16.0
06ac4bc 
Signed-off-by carmenbianca
@OCA-git-bot
Copy link
Contributor

@carmenbianca your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-120-by-carmenbianca-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

1 similar comment
@OCA-git-bot
Copy link
Contributor

@carmenbianca your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-120-by-carmenbianca-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@carmenbianca
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-120-by-carmenbianca-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 2, 2024
@OCA-git-bot
Merge PR #120 into 16.0
e508fa0 
Signed-off-by carmenbianca
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-120-by-carmenbianca-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b918a0b into OCA:16.0 May 2, 2024
1 of 5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a56ffd0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polchampion polchampion polchampion approved these changes

@carmenbianca carmenbianca carmenbianca approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@victor-champonnois @polchampion @carmenbianca @OCA-git-bot @huguesdk