[16.0][FIX] validate belgian national register number on website form #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check that the belgian national registry number is valid before validating the subscription request, to avoid creating and posting the capital release request and then having it rolled back.
huguesdk
force-pushed
the
16.0-fix-validate_be_national_register_number_website_form
branch
3 times, most recently
from
f8df873 to
6f0b169
Compare
* validate belgian national register number on website form. * fix style of belgian national register number field. * only display belgian national register number field if display_national_number is true.
huguesdk
force-pushed
the
16.0-fix-validate_be_national_register_number_website_form
branch
from
6f0b169 to
14f7b78
Compare
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 72d7e5c. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
display_national_numberis true.note that this branch is created on top of #127 (because it depends on it). only the last commit is part of this branch and should be reviewed.