[IMP][15.0] datev_export_xml: Validation and small issues #156
Conversation
…n invoices. Fix some edge cases like fully discounted lines
fkantelberg
force-pushed
the
15.0-imp-datev-xml
branch
from
45be24b to
7ce50a8
Compare
|
@tv-openbig This is the forward port of #155 |
| schema = etree.XMLSchema(etree.parse(schema)) | ||
| schema.assertValid(root) | ||
| except (etree.DocumentInvalid, etree.XMLSyntaxError) as e: | ||
| _logger.warning(etree.tostring(root)) | ||
|
|
||
| if invoice: | ||
| invoice.datev_validation = str(e) |
There was a problem hiding this comment.
This data is not going to be written as the latter raise rollbacks the transaction.
There was a problem hiding this comment.
This is correct for the normal export but not for the validation feature (action_validate)
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
@tv-openbig your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-156-by-tv-openbig-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
FYI our customer found an issue with it. When you have multiple taxes on an invoice it crashes in the qweb and no usable exception is given. Multiple taxes are checked in |
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at b1c1496. Thanks a lot for contributing to OCA. ❤️ |
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 1849feb. Thanks a lot for contributing to OCA. ❤️ |
Forward port of #155