[18.0][MIG] mail_tracking: Migration to 18.0 #1

trisdoan · 2024-11-05T08:55:46Z

Note

missing commits from 14.0 are ported in [17.0][FW] Port missing commits social#1475

Big changes in 18.0

Backend

access_rights_uid was removed from _search() changed in odoo/odoo@21d023e
_prepare_outgoing_list got extra param mail_server in odoo/odoo@97ce084
_message_format was converted to use store and message_format_extras was removed in odoo/odoo@52df49e. As consequences, _extras_to_store is introduced
tools.ustr is considered to be inefficient and flagged as deprecated in odoo/odoo@64a5724. Hence, is replaced by exception_to_unicode for the same effect.

Frontend

mail.messaging service was removed in odoo/odoo@683258b
initMessagingCallback is removed in odoo/odoo@4f8087f. So new entry point is created for store onStarted instead.
mail.thread service was removed in odoo/odoo@65e5a79

This changes

Store helper was introduced in odoo/odoo@c032ccf. As consequences, failed data is now passed through Store.
- As a side effect, it is also easier to do the search filter_failed(thread) with Store service
As Odoo uses less Jquery, the module runs fine with vanilla. This impacts mail_tracking/static/src/components/message_tracking/message_tracking.esm.js
Took this chance to
- replace % format with f-string
- Improve permission constraint
  - Context: This commit porting from 12.0
  - Approach is summarized as below:
    1. When do the searching,
      - First, use the query to get result
      - Browse those id with the query + Remove any forbidden records
      - Return the accessible records in form of query, to continue the process
    2. When user read the records
      - The low-level method _check_access will discard forbidden records + raise exception
  - Added security check test
- Resolve FIXME, which was added in OCA/social@7560443, then was resolved in odoo/odoo@7fe02c9

Result

* [ADD] mail_tracking addon * Add description icon * Fixes remarked * Fix Travis error * Remarks fixed

…ent events (#82) [IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes

* Improve tests * Show trackings even if partner removed * Disable CSRF protection to webhooks controllers

…s and contacts to bounce (#133)

…oved (#132)

As regular users can't access this object.

* [FIX] Only one data-odoo-tracking-email tag in each email * [FIX] Get status even in multicompany instances

On our server, queries based on "mail_tracking_event"."tracking_email_id" improved from 501,924 ms to 1,840 ms queries based on "mail_tracking_email"."mail_message_id" improved from 167,436 ms to 3,223 ms The last ones are run several times when a thread has many messages

Currently translated at 100.0% (82 of 82 strings) Translation: social-11.0/social-11.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-11-0/social-11-0-mail_tracking/fr/

Closes #303

For giving more priority to other buttons like the invoices one.

Currently translated at 96.3% (79 of 82 strings) Translation: social-11.0/social-11.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-11-0/social-11-0-mail_tracking/ca/

Or infinite recursions will happen on other `write` overwrites, like the one that happens on `mass_mailing_partner`.

TDu · 2024-11-05T14:17:32Z

mail_tracking/models/mail_message.py

+        tracking_ids = self.env["mail.tracking.email"]._search(
+            [("state", f"{tracking_operator}", failed_states)]
+        )


This seems very costly for a production database with 10 or 100 thousand of record in mail.tracking.email, it will return a lot of records.
I like better the previous implementation below,
( "mail_tracking_ids.state", "in" if value else "not in", list(self.get_failed_states()), ),

Indeed, I agree

chienandalu

As for comment OCA/social#1476 (comment)

Look like it gets the same issue in 17.0

No, it doesn't. You can try in a runboat. If don't remember it wrong there was a bus call in python that notified the state to the client so we didn't need to reload the whole page risking to loose context like the breadcrumb path...

mmequignon

I agree with @TDu comment about the double search, it should be done in 1.

trisdoan · 2024-11-11T08:40:26Z

~~DRAFT: working on reactivity of reviewed failed msg~~

trisdoan · 2024-11-12T04:23:16Z

Hello @TDu, @ivantodorovich , @mmequignon, I updated the _search_is_failed_message

trisdoan · 2024-11-12T04:29:03Z

Hello @chienandalu,

I just added this patch + use bus to fix the reactivity both in Discuss and Chatter, here is result:

mail_tracking_v18.webm

Yes, you'r right, it works in v17 but only in Chatter, it does not work in Discuss (I ran in gevent mode), is that the same on your local ?

mail_tracking_v17.webm

mmequignon

fine by me

OCA-git-bot · 2024-12-02T10:39:26Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

hbrunn · 2024-12-06T11:26:09Z

/ocabot merge nobump

OCA-git-bot · 2024-12-06T11:26:18Z

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-1-by-hbrunn-bump-nobump, awaiting test results.

Signed-off-by hbrunn

OCA-git-bot · 2024-12-06T11:30:48Z

It looks like something changed on 18.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 18.0-ocabot-merge-pr-1-by-hbrunn-bump-nobump, awaiting test results.

OCA-git-bot · 2024-12-06T11:35:17Z

Congratulations, your PR was merged at 4d83b95. Thanks a lot for contributing to OCA. ❤️

antespi and others added 30 commits November 5, 2024 15:54

[8.0][ADD] mail_tracking addon (#67)

a5edb4d

* [ADD] mail_tracking addon * Add description icon * Fixes remarked * Fix Travis error * Remarks fixed

[8.0][IMP][mail_tracking] Speed installation time and discard concurr…

1d5d858

…ent events (#82) [IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes

[FIX] Update email_score when email changes

2cdd736

[MIG] mail_tracking

927a8d2

* Improve tests * Show trackings even if partner removed * Disable CSRF protection to webhooks controllers

[FIX] mail_tracking: Typo

cea5de8

[MIG] Make modules uninstallable

32f44db

[MIG] mail_tracking: Migrated to 10.0

2818960

[IMP] mail_tracking performance and bounce process (#103)

a2913b1

[IMP] mail_tracking: Allow to define a custom mail_tracking base url

c0a8ff2

Add access to portal/public user to his own email trackings

fbf905a

[8.0][FIX][mail_tracking] Use event recipient address to find partner…

d0e733d

…s and contacts to bounce (#133)

[9.0][FIX][mail_tracking] Control exception when mail_message was rem…

0bde843

…oved (#132)

[FIX] Sender label is repeated in search fields

5615bd5

[FIX][9.0] partner buttons view on enterprise

d88cee2

[FIX] mail_tracking: Obtain outgoing server with sudo

3dc252a

As regular users can't access this object.

[IMP] Shut mock exceptions up

d2fe121

[9.0][IMP] mail_tracking: Improve view with error details

efed864

[FIX] mail_tracking: bugfixes (#199)

3223f5b

* [FIX] Only one data-odoo-tracking-email tag in each email * [FIX] Get status even in multicompany instances

[FIX] mail_tracking js could break other modules using chat_manager

cf4e7a1

[MIG] mail_tracking: Migration to 11.0

feebaa5

Translated using Weblate (French) [ci skip]

2881771

Currently translated at 100.0% (82 of 82 strings) Translation: social-11.0/social-11.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-11-0/social-11-0-mail_tracking/fr/

[IMP] mail_tracking: email score performance (#299)

fd33486

Fix README.rst images not visible in GitHub and Odoo

afdebdc

Closes #303

[IMP] mail_tracking: Put button box at the end of the view

eceba5f

For giving more priority to other buttons like the invoices one.

Translated using Weblate (Catalan)

d8f6ec7

Currently translated at 96.3% (79 of 82 strings) Translation: social-11.0/social-11.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-11-0/social-11-0-mail_tracking/ca/

[MIG] mail_tracking: Migration to 12.0

010f08a

[FIX] mail_tracking: Don't call write inside other write

651b9eb

Or infinite recursions will happen on other `write` overwrites, like the one that happens on `mass_mailing_partner`.

[IMP] mail_tracking: Cc

b6a9c62

[MIG] mail_tracking: Adapt Cc to 12.0

50fc696

TDu reviewed Nov 5, 2024

View reviewed changes

chienandalu reviewed Nov 5, 2024

View reviewed changes

mmequignon reviewed Nov 7, 2024

View reviewed changes

trisdoan force-pushed the 18.0-mig-mail_tracking branch from b9359cc to 3899c6c Compare November 11, 2024 08:39

trisdoan marked this pull request as draft November 11, 2024 08:40

trisdoan force-pushed the 18.0-mig-mail_tracking branch 2 times, most recently from cc947a6 to c37318b Compare November 12, 2024 04:16

[MIG] mail_tracking: Migration to 18.0

974b492

trisdoan force-pushed the 18.0-mig-mail_tracking branch from c37318b to 974b492 Compare November 12, 2024 04:19

trisdoan marked this pull request as ready for review November 12, 2024 04:21

trisdoan requested review from mmequignon, TDu, chienandalu and ivantodorovich November 12, 2024 04:29

mmequignon approved these changes Dec 2, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Dec 2, 2024

OCA-git-bot added a commit that referenced this pull request Dec 6, 2024

Merge PR #1 into 18.0

9b14f1d

Signed-off-by hbrunn

OCA-git-bot added the bot is merging ⏳ label Dec 6, 2024

OCA-git-bot merged commit bb6fa1f into OCA:18.0 Dec 6, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] mail_tracking: Migration to 18.0 #1

[18.0][MIG] mail_tracking: Migration to 18.0 #1

trisdoan commented Nov 5, 2024

TDu Nov 5, 2024

ivantodorovich Nov 5, 2024

chienandalu left a comment

mmequignon left a comment

trisdoan commented Nov 11, 2024 •

edited

Loading

trisdoan commented Nov 12, 2024

trisdoan commented Nov 12, 2024 •

edited

Loading

mmequignon left a comment

OCA-git-bot commented Dec 2, 2024

hbrunn commented Dec 6, 2024

OCA-git-bot commented Dec 6, 2024

OCA-git-bot commented Dec 6, 2024

OCA-git-bot commented Dec 6, 2024

[18.0][MIG] mail_tracking: Migration to 18.0 #1

[18.0][MIG] mail_tracking: Migration to 18.0 #1

Conversation

trisdoan commented Nov 5, 2024

Note

Big changes in 18.0

Backend

Frontend

This changes

Result

TDu Nov 5, 2024

Choose a reason for hiding this comment

ivantodorovich Nov 5, 2024

Choose a reason for hiding this comment

chienandalu left a comment

Choose a reason for hiding this comment

mmequignon left a comment

Choose a reason for hiding this comment

trisdoan commented Nov 11, 2024 • edited Loading

trisdoan commented Nov 12, 2024

trisdoan commented Nov 12, 2024 • edited Loading

mmequignon left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Dec 2, 2024

hbrunn commented Dec 6, 2024

OCA-git-bot commented Dec 6, 2024

OCA-git-bot commented Dec 6, 2024

OCA-git-bot commented Dec 6, 2024

trisdoan commented Nov 11, 2024 •

edited

Loading

trisdoan commented Nov 12, 2024 •

edited

Loading