Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][IMP] sale_margin_security: Avoid display margin in measures pivot view. #188

Merged
merged 1 commit into from
Nov 21, 2023
Merged

[15.0][IMP] sale_margin_security: Avoid display margin in measures pivot view. #188

merged 1 commit into from
Nov 21, 2023

Conversation

carlosdauden
Copy link
Contributor

Set group_sale_margin_security in all sensible fields.

@Tecnativa
ping @sergio-teruel

@carlosdauden
[IMP] sale_margin_security: Avoid display margin in measures pivot view.
e4649db 
Set group_sale_margin_security in all sensible fields.
@OCA-git-bot
Copy link
Contributor

Hi @sergio-teruel,
some modules you are maintaining are being modified, check this out!

pedrobaeza
pedrobaeza approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-188-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 21, 2023
@OCA-git-bot
Merge PR #188 into 15.0
8a07a13 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-188-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-188-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a094e3b into OCA:15.0 Nov 21, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6e25d3b. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-IMP-sale_margin_security-avoid_margin_pivot_view branch November 21, 2023 21:52
@pedrobaeza pedrobaeza mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergio-teruel sergio-teruel sergio-teruel approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlosdauden @OCA-git-bot @pedrobaeza @sergio-teruel