[FIX] product_margin_classification: compute correctly fields in multi company context. #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i company context. new computed and stored fields depends on standard_price that is company dependant. As a result, add a warning in the ROADMAP section, to explicit current module limitation. Ensure that computation is done in the context of the company of the product, to avoid to base computation on bad / null standard prices
rvalyi
reviewed
Jan 8, 2025
| @@ -91,6 +91,11 @@ Known issues / Roadmap | |||
| due to the poor design of Odoo product module. | |||
| This issue can be maybe fixed in new version of Odoo. | |||
|
|
|||
| * This module will not work for products that available on many | |||
There was a problem hiding this comment.
s/that available/that are available/
s/on many/in several/
rvalyi
reviewed
Jan 8, 2025
rvalyi
reviewed
Jan 8, 2025
| * This module will not work for products that available on many | ||
| companies, because this module introduces stored fields, that can | ||
| not be company dependant, and the fields depends on ``standard_price`` | ||
| that is company dependant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new computed and stored fields depends on standard_price that is company dependant. As a result, add a warning in the ROADMAP section, to explicit current module limitation. Ensure that computation is done in the context of the company of the product, to avoid to base computation on bad / null standard prices