[16.0][ADD] sale_rental #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 26, 2024 12:33
|
Please preserve commit history. You should change the command including both remotes. And check also CI. |
Ok, that seems like quite the effort since we are moving a module between repos here. The original PR has 61 commits and not all of can be merged into the repo. I have to take a look at all the commits and cherrypick accordingly. I can try this, except if you have a better idea |
|
New PR with preserved commit history: #46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the module sale_rental to vertical-rental. This module was in sale-workflow in previous versions, but it was suggested that it is moved to vertical-rental starting with version 16.0
see this PR: OCA/sale-workflow#2325
the actual migration work was done by @Murtaza-OSI