[16.0][ADD] website_recaptcha_v2_form #1076

edescalona · 2024-12-06T13:22:18Z

Adding recaptcha version 2 for the form snippets and also in the login, password reset and register forms.

…orm snippets and also in the login, password reset and register forms. [FIX] Tests [FIX] Ttests [IMP] Add new tests [IMP] Add new tests

Christian-RB

Thanks for your contribution, check my comments please and remember to squash your commits into one.

Christian-RB · 2024-12-10T14:04:51Z

website_recaptcha_v2_form/controllers/main.py

+SIGN_UP_REQUEST_PARAMS.add("g-recaptcha-response")
+
+
+class BinhexHome(Home):


Don't use company name in classes, functions nor variables, it should only appear in the manifest as author and the contributors readme.

Suggested change

class BinhexHome(Home):

class RecaptchaHome(Home):

ok @Christian-RB

Christian-RB · 2024-12-10T14:08:09Z

website_recaptcha_v2_form/models/website.py

+    # --------------------------------------------------
+    # METHODS
+    # --------------------------------------------------
+    """
+        Validating that the recaptcha sent is correct
+        @params:
+            kw: Data sent from the form
+    """
+


I think you could remove this comments

Suggested change

# --------------------------------------------------

# METHODS

# --------------------------------------------------

"""

Validating that the recaptcha sent is correct

@params:

kw: Data sent from the form

"""

Christian-RB · 2024-12-10T14:11:56Z

website_recaptcha_v2_form/readme/CONTRIBUTORS.md

+* `BINHEX <https://www.binhex.cloud>`:
+
+  * Edilio Escalona Almira


Suggested change

* `BINHEX <https://www.binhex.cloud>`:

* Edilio Escalona Almira

- `Binhex <https://binhex.cloud>`__:

- Edilio Escalona Almira

Christian-RB · 2024-12-10T14:14:41Z

website_recaptcha_v2_form/readme/CONFIGURE.md

+#. Go to **Website > Configuration > Settings**.
+
+#. Search 'reCAPTCHA v2' option.
+
+![reCaptcha v2](../static/src/img/readme/img.png)
+
+#. Click the link [Get reCAPTCHA v2 keys](https://www.google.com/recaptcha/admin)
+   to generate the keys needed to use the recaptcha.
+
+![Get reCAPTCHA v2 keys](../static/src/img/readme/img_1.png)
+
+#. Fill in the generated **Site Key** and **Secret key**.
+
+![reCAPTCHA v2 keys](../static/src/img/readme/img_2.png)


I think it would be better to create a link to the original README in website_recaptcha_v2 instead of duplicating the imgs and information here.

Oh sorry I just saw that the website_recaptcha_v2 module doesn't contains those imgs. It's ok the way it is.

Hi @Christian-RB , ok no problem, thanks for your comments.

# This is the 1st commit message: [IMP] Add tests # This is the commit message OCA#2: [IMP] Add tests # This is the commit message OCA#3: [FIX] Tests # This is the commit message OCA#4: [FIX] Tests [ADD] Tests [FIX] Tests [FIX] Tests [ADD] Tests [ADD] Tests [FIX] Tests [ADD] Tests [ADD] Tests [REM] Tests [ADD] Tests [ADD] Tests [ADD] Tests

jorgeglez1990

Greetings,
It has been functionally tested, and it works correctly except when, on /web/login, we log in without verifying the reCAPTCHA, which results in a 500: Internal Server Error.

edescalona · 2024-12-25T21:06:44Z

Greetings, It has been functionally tested, and it works correctly except when, on /web/login, we log in without verifying the reCAPTCHA, which results in a 500: Internal Server Error.

hello @jorgeglez1990 I'll check it out now, thanks for your cooperation.

nobuQuartile · 2025-01-07T05:42:54Z

website_recaptcha_v2_form/models/res_config_settings.py

+                ]
+            )
+        )
+        site_key_old = views_recaptcha.arch_db.split('data-sitekey="')


Thank you for your contribution.
Let me comment on the minor error I had when I tried to use the module you created.

When I tried to open the Setting app with this module on runboat, I got the following error.
It's because search() result ir.ui.view() is empty
I think just doing an if branch will solve this.
What do @edescalona think?

File "/opt/odoo/odoo/http.py", line 1653, in _serve_db return service_model.retrying(self._serve_ir_http, self.env) File "/opt/odoo/odoo/service/model.py", line 133, in retrying result = func() File "/opt/odoo/odoo/http.py", line 1680, in _serve_ir_http response = self.dispatcher.dispatch(rule.endpoint, args) File "/opt/odoo/odoo/http.py", line 1884, in dispatch result = self.request.registry['ir.http']._dispatch(endpoint) File "/opt/odoo/addons/website/models/ir_http.py", line 237, in _dispatch response = super()._dispatch(endpoint) File "/opt/odoo/odoo/addons/base/models/ir_http.py", line 154, in _dispatch result = endpoint(**request.params) File "/opt/odoo/odoo/http.py", line 734, in route_wrapper result = endpoint(self, *args, **params_ok) File "/opt/odoo/addons/web/controllers/dataset.py", line 42, in call_kw return self._call_kw(model, method, args, kwargs) File "/opt/odoo/addons/web/controllers/dataset.py", line 33, in _call_kw return call_kw(request.env[model], method, args, kwargs) File "/opt/odoo/odoo/api.py", line 468, in call_kw result = _call_kw_multi(method, model, args, kwargs) File "/opt/odoo/odoo/api.py", line 453, in _call_kw_multi result = method(recs, *args, **kwargs) File "/opt/odoo/odoo/models.py", line 6633, in onchange record._onchange_eval(name, field_onchange[name], result) File "/opt/odoo/odoo/models.py", line 6344, in _onchange_eval method_res = method(self) File "/mnt/data/odoo-addons-dir/website_recaptcha_v2_form/models/res_config_settings.py", line 19, in onchange_recaptcha_v2_site_key site_key_old = views_recaptcha.arch_db.split('data-sitekey="') AttributeError: 'bool' object has no attribute 'split' The above server error caused the following client error: null

Suggested change

site_key_old = views_recaptcha.arch_db.split('data-sitekey="')

if views_recaptcha:

site_key_old = views_recaptcha.arch_db.split('data-sitekey="')

Hi @nobuQuartile , if it could be an option, I will review it and let you know as soon as possible, thanks for yout comment.

edescalona · 2025-01-07T06:51:08Z

Hi @nobuQuartile , I solved the error you mentioned. When I can, please check and confirm. Thanks.

yostashiro · 2025-01-07T07:46:25Z

website_recaptcha_v2_form/models/res_config_settings.py

+    _inherit = "res.config.settings"
+
+    @api.onchange("recaptcha_v2_site_key")
+    def onchange_recaptcha_v2_site_key(self):


I thought it would be more appropriate to extend the write() method instead of using onchange here.

@edescalona Excuse me. There was an error I pointed out yesterday, which you corrected, but this way of doing things may be more appropriate: it is better to stop unnecessary execution occurring on change than to branch on IF. Sorry for making so many corrections.

nobuQuartile · 2025-01-07T08:58:29Z

Hi @nobuQuartile , I solved the error you mentioned. When I can, please check and confirm. Thanks.

Hi @edescalona, I checked and confirmed the problem is solved at the ruboat. Thanks.

edescalona mentioned this pull request Dec 6, 2024

[16.0][ADD] website_recaptcha_v2_login #1075

Closed

[ADD] website_recaptcha_v2_form: Adding recaptcha version 2 for the f…

8b4f216

…orm snippets and also in the login, password reset and register forms. [FIX] Tests [FIX] Ttests [IMP] Add new tests [IMP] Add new tests

edescalona force-pushed the 16.0-add-website_recaptcha_v2_form branch from 74618c9 to 8b4f216 Compare December 6, 2024 16:27

edescalona added 4 commits December 6, 2024 11:47

[FIX] Tests

a127175

[IMP] Readme

2ca2616

[IMP] Readme

4fc2af4

[IMP] Valid send data website form with recaptcha

134a253

Christian-RB suggested changes Dec 10, 2024

View reviewed changes

edescalona added 6 commits December 10, 2024 10:28

[IMP] website_recaptcha_v2_form: Change name class

c2bdba2

[FIX] website_recaptcha_v2_form: Remove comments

34c7b4f

[FIX] website_recaptcha_v2_form: Correcting CONTRIBUTORS file structure

618984e

[FIX] website_recaptcha_v2_form: Readme

965ce6a

[FIX] Rename import class

34ab7a1

edescalona force-pushed the 16.0-add-website_recaptcha_v2_form branch from cf7f6d2 to e07469c Compare December 24, 2024 03:19

jorgeglez1990 suggested changes Dec 24, 2024

View reviewed changes

edescalona added 3 commits December 25, 2024 17:40

[IMP] Update sitekey on web forms created by changing settings

a3c1a03

[IMP] Add tests

b8c82d8

[IMP] Add tests

fe0d892

nobuQuartile reviewed Jan 7, 2025

View reviewed changes

[FIX] Valid views with recaptcha

4c47d1e

yostashiro reviewed Jan 7, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][ADD] website_recaptcha_v2_form #1076

[16.0][ADD] website_recaptcha_v2_form #1076

edescalona commented Dec 6, 2024

Christian-RB left a comment

Christian-RB Dec 10, 2024

edescalona Dec 10, 2024

Christian-RB Dec 10, 2024

Christian-RB Dec 10, 2024

Christian-RB Dec 10, 2024

edescalona Dec 10, 2024

Christian-RB Dec 10, 2024

edescalona Dec 10, 2024

jorgeglez1990 left a comment

edescalona commented Dec 25, 2024

nobuQuartile Jan 7, 2025 •

edited

Loading

edescalona Jan 7, 2025

edescalona commented Jan 7, 2025

yostashiro Jan 7, 2025

nobuQuartile Jan 8, 2025

nobuQuartile commented Jan 7, 2025

		SIGN_UP_REQUEST_PARAMS.add("g-recaptcha-response")


		class BinhexHome(Home):

		* `BINHEX <https://www.binhex.cloud>`:

		* Edilio Escalona Almira

	site_key_old = views_recaptcha.arch_db.split('data-sitekey="')
	if views_recaptcha:
	site_key_old = views_recaptcha.arch_db.split('data-sitekey="')

[16.0][ADD] website_recaptcha_v2_form #1076

Are you sure you want to change the base?

[16.0][ADD] website_recaptcha_v2_form #1076

Conversation

edescalona commented Dec 6, 2024

Christian-RB left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jorgeglez1990 left a comment

Choose a reason for hiding this comment

edescalona commented Dec 25, 2024

nobuQuartile Jan 7, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

edescalona commented Jan 7, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nobuQuartile commented Jan 7, 2025

nobuQuartile Jan 7, 2025 •

edited

Loading