[14.0][FIX] shopfloor checkout scanning a lot and quantity done #785
Conversation
TDu
changed the title
| # When lots are as units outside of packages, we can select them for | ||
| # packing, but if they are in a package, we want the user to scan the packages. | ||
| # If the product is only in one package though, scanning the lot selects | ||
| # the package. |
There was a problem hiding this comment.
I'm not sure to understand in what this comment was wrong?
There was a problem hiding this comment.
It was not wrong, I thought it was clearer to have the explanation on each if cases
There was a problem hiding this comment.
Both is good IMO, to get the big picture before entering in the "if/else" dance, and each block gets its own comment
There was a problem hiding this comment.
But it is the same comment split so each comment is exactly were it is meaningful.
There was a problem hiding this comment.
It was to get the big picture before reading all the code details. But OK
| picking, selection_lines, packages, prefill_qty=prefill_qty, **kw | ||
| # The lot is only in one package | ||
| # Related lines are the one in the same package | ||
| related_lines = selection_lines.filtered( |
There was a problem hiding this comment.
I don't know what means "related lines" here compared to "line_to_update" or "lines" below. Can you give a definition in a comment?
There was a problem hiding this comment.
I have added a comment above with the declaration of the variable
There was a problem hiding this comment.
So if the related lines are the lines belonging to the same package than the lot line, we want to scan a package right? I don't know where this is happening.
TDu
force-pushed
the
14-sf-checkout-fix-bug-select-line
branch
from
4b21bf2 to
67b7642
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
jbaudoux
added
no stale
mmequignon
force-pushed
the
14-sf-checkout-fix-bug-select-line
branch
from
67b7642 to
96c223e
Compare
With the no-prefill-qty option not set. When selecting a line by scanning a lot, all the lines with the same product related to that lot. Have their quantity done set! But only the line with the lot scanned should have the quantity done updated.
With the no-prefill-qty option not set. When selecting a line by scanning a lot, that is in a package. All the lines in the package have their quantity done set! But only the line with the lot scanned should have the quantity done updated.
When scanning a lot, if the lot is on multiple lines only one of the lines should have the quantity updated.
mmequignon
force-pushed
the
14-sf-checkout-fix-bug-select-line
branch
from
96c223e to
66ee1ca
Compare
No description provided.