[IMP] stock_available_to_promise_release: set move to need release after pick cancel

[sbejaoui]

if we manually cancel one of picking chain we set the dest moves to need_release so they can be released again

[lmignon]

Makes sense (Code review only)

[jbaudoux]

There is also the case where you don't create a backorder on the pick when you process a partial quantity. In this case, I don't think action_cancel is called. I'll see to solve that one

[jbaudoux]

You cannot set the complete move as releasable. Only the canceled quantity can be releasable.
If you have a ship of 10 units. You pick 6 and you cancel the backorder of 4, then you cannot mark the 10 units back as releasable.

You also forgot to manage the case where it's more steps than pick-ship, like pick-pack-ship. Seems you put the pack as need_release. Anyway, that's more complicate than that.

[lmignon]

@jbaudoux I'm on it. A first test suggests that this code introduces malicious behavior if a partial quantity is picked and the release process is called again on the ship. The new pick is generated for the original quantity without taking into account what has already been prepared.

[jbaudoux]

There is also the case where you don't create a backorder on the pick when you process a partial quantity. In this case, I don't think action_cancel is called. I'll see to solve that one

Fixed here #819 (comment) in commit 948637a

[jbaudoux]

There is also the case where you don't create a backorder on the pick when you process a partial quantity. In this case, I don't think action_cancel is called. I'll see to solve that one

Fixed here #819 (comment) in commit 948637a

And here #905