[16.0] shopfloor: location_content_transfer: get_work additional domain and sort key. #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
lmignon
force-pushed
the
16.shopfloor-location-content-transfer-adv
branch
2 times, most recently
from
af89661 to
6ccbfa5
Compare
lmignon
added a commit
to acsone/wms
that referenced
this pull request
Jul 12, 2024
rousseldenis
force-pushed
the
16.shopfloor-location-content-transfer-adv
branch
2 times, most recently
from
e56b453 to
e05e7aa
Compare
lmignon
force-pushed
the
16.shopfloor-location-content-transfer-adv
branch
2 times, most recently
from
30deba0 to
e9e1549
Compare
jbaudoux
requested changes
Aug 27, 2024
|
@jbaudoux If I remove the possibility to search for picking in an other picking type than the one provided by the menu if specified, I'm no more able to support the use case in the location_content_transfer scenario when content has different picking type than menu, and the menu is configured with the option to unreserve. In such a case, content must be unreserved, new moves created and the previous content re-reserved. That why I need this new |
lmignon
force-pushed
the
16.shopfloor-location-content-transfer-adv
branch
from
e9e1549 to
504f3a3
Compare
The priority lines count must be the sum of operations linked to a priority move, while the priority pickings count must be the sum of priority pickings.
Ensures opertations assigned to current user are always first when sorting lines
Never return operations from pickings assigned to an other user when the method is called with the parameter 'match_user' set to True
If a location is not provided we take the one from the picking type by default
The scenario now uses the 'search_move_line' action to search for operations to perform when the user requests work. This eliminates duplicate code between the scenario and the 'search_move_line' action.
For scenario using the 'search_move_line' action to get lines to work on, it's now possible to provide an additional domain and a custom sort key code when configuring menu using these scenario. This applies to the location_content_transfer scenario and partialy to the zone_picking one
lmignon
force-pushed
the
16.shopfloor-location-content-transfer-adv
branch
2 times, most recently
from
b977550 to
62d227b
Compare
|
@jbaudoux Your last comment is now implemented into the last commit. |
lmignon
force-pushed
the
16.shopfloor-location-content-transfer-adv
branch
from
62d227b to
6c647b6
Compare
|
@jbaudoux done |
jbaudoux
reviewed
Oct 14, 2024
To disable the filtering of move line based on specific picking types, the additional parameter ‘enforce_picking_types’ had to be set to True when calling the method 'search_move_lines' of the 'hopfloor.search.move.line' action. The name of this parameter was not really relevant and its meaning conflicted with another parameter ‘enforce_package_types’. To avoid this situation, the semantics of the ‘picking_type’ parameter have been modified so that it can be explicitly stated that the search is not on a particular picking type if an empty recordset is passed as a parameter. Previously, if the parameter was None or an empty recordset, the filtering was forced on the picking types specified into the work context. Translated with DeepL.com (free version)
lmignon
force-pushed
the
16.shopfloor-location-content-transfer-adv
branch
from
6c647b6 to
d3fc8c3
Compare
jbaudoux
approved these changes
Oct 14, 2024
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at bc58cd6. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial aim of this PR is to enable the 'location_content_transfer' scenario to be configured more precisely.
It aims to:
When analysing the code, I found that there was an inconsistency between the code used to create the menu counters and the one used to find the transactions in the 'location_content_transfer' scenario. The code in the latter scenario was functionally identical to the one used for menus and zone_picking. Harmonisation work has therefore been carried out to eliminate this inconsistency.
As result, a generic solution has been put in place for scenarios using the 'search_move_line' action to find the operations to be carried out, so that the menus can be used to configure an additional domain to be applied by default and the method for sorting operations.