[14.0][FIX] delivery_carrier_preference: fix perf issue when editing packaging from product form #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On products having a lot of moves, editing packaging from product form is triggering heavy computation as a side-effect, even if the 'estimated_shipping_weight' field is not stored. Odoo is fetching moves and then pickings of these moves through this line: https://github.com/odoo/odoo/blob/cc0060e889603eb2e47fa44a8a22a70d7d784185/odoo/models.py#L5904
henrybackman
approved these changes
Dec 17, 2024
simahawk
approved these changes
Dec 18, 2024
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at cd82181. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On products having a lot of moves, editing packaging from product form is triggering heavy computation as a side-effect, even if the
estimated_shipping_weightfield is not stored.Odoo is fetching moves and then pickings of these moves through this line:
https://github.com/odoo/odoo/blob/cc0060e889603eb2e47fa44a8a22a70d7d784185/odoo/models.py#L5904
This can be reproduced on a demo DB with only
delivery_carrier_preferenceinstalled (putting apdbin the Odoo line above shows thatpicking_idis accessed and with enough moves in DB, a latency can be experienced).