Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suricata: fix list-keywords option #12124

Closed
wants to merge 2 commits into from
Closed

Conversation

regit
Copy link
Contributor

@regit regit commented Nov 17, 2024

The list keywords option was crashing due to improper init.

Ticket: 7397

Contribution style:

Our Contribution agreements:

Changes (if applicable):

Link to ticket: https://redmine.openinfosecfoundation.org/issues/7397

Describe changes:

  • fix list keywords

The list keywords option was crashing due to improper init.

Ticket: 7397
@regit regit requested a review from victorjulien as a code owner November 17, 2024 18:48
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.77%. Comparing base (5d766df) to head (377718d).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #12124       +/-   ##
===========================================
- Coverage   62.68%   49.77%   -12.91%     
===========================================
  Files         840      909       +69     
  Lines      153669   257884   +104215     
===========================================
+ Hits        96323   128369    +32046     
- Misses      57346   129515    +72169     
Flag Coverage Δ
fuzzcorpus 60.93% <0.00%> (?)
livemode 19.43% <0.00%> (?)
pcap 44.40% <0.00%> (?)
suricata-verify 62.68% <0.00%> (+<0.01%) ⬆️
unittests 8.98% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@suricata-qa
Copy link

ERROR:

ERROR: QA failed on SURI_TLPR1_alerts_cmp.

Pipeline 23399

@victorjulien
Copy link
Member

"Attention: Patch coverage is 0%"... a CI check would be a good idea I think :)

Add the 2 command line options to coverage build.
@regit regit requested a review from jasonish as a code owner November 19, 2024 20:12
@regit
Copy link
Contributor Author

regit commented Nov 19, 2024

"Attention: Patch coverage is 0%"... a CI check would be a good idea I think :)

I was thinking about adding a few command run (keywords and app layer list) in the CI. But I was wondering in which part of the CI it should be done. I've tried something and pushed an additional commit.

@suricata-qa
Copy link

Information:

ERROR: QA failed on SURI_TLPR1_alerts_cmp.

field baseline test %
SURI_TLPR1_stats_chk
.app_layer.flow.dcerpc_tcp 40 42 105.0%

Pipeline 23436

@victorjulien victorjulien added this to the 8.0 milestone Nov 20, 2024
@inashivb
Copy link
Member

"Attention: Patch coverage is 0%"... a CI check would be a good idea I think :)

I was thinking about adding a few command run (keywords and app layer list) in the CI. But I was wondering in which part of the CI it should be done. I've tried something and pushed an additional commit.

Thanks. Do you know why did the coverage not increase?

@victorjulien
Copy link
Member

Merged in #12140, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants