-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suricata: fix list-keywords option #12124
Conversation
The list keywords option was crashing due to improper init. Ticket: 7397
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12124 +/- ##
===========================================
- Coverage 62.68% 49.77% -12.91%
===========================================
Files 840 909 +69
Lines 153669 257884 +104215
===========================================
+ Hits 96323 128369 +32046
- Misses 57346 129515 +72169
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ERROR: ERROR: QA failed on SURI_TLPR1_alerts_cmp. Pipeline 23399 |
"Attention: Patch coverage is 0%"... a CI check would be a good idea I think :) |
Add the 2 command line options to coverage build.
I was thinking about adding a few command run (keywords and app layer list) in the CI. But I was wondering in which part of the CI it should be done. I've tried something and pushed an additional commit. |
Information: ERROR: QA failed on SURI_TLPR1_alerts_cmp.
Pipeline 23436 |
Thanks. Do you know why did the coverage not increase? |
Merged in #12140, thanks! |
The list keywords option was crashing due to improper init.
Ticket: 7397
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7397
Describe changes: