Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple stream bypass from TLS encrypted bypass v8 #12387

Closed
wants to merge 4 commits into from
Closed

Decouple stream bypass from TLS encrypted bypass v8 #12387

wants to merge 4 commits into from
+121 −37

Conversation

lukashino
Copy link
Contributor

@lukashino lukashino commented Jan 13, 2025 •
edited
Loading

Following up on #12249

Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6788

Describe changes:
v8:

v7

  • Style guide changes as suggested in the prev PR
  • Encryption Handling has now three states, similar to TLS
  • rebased

v6

  • rebased

v5

  • rebased
  • added upgrade section
  • fixed docs - Thanks Juliana
  • SV tests should pass now

v4

  • rebased
  • changed SSH bypass defaults to hopefully be in sync with the previous settings

v3

  • added SSH app-layer option encryption-handling allowing to choose whether to continue inspection on SSH once it turns encrypted
  • added SV tests
  • minor docs updates

SV_BRANCH=OISF/suricata-verify#2233

Lukas Sismis and others added 4 commits January 13, 2025 13:09
@lukashino
ssh: add option to select behavior of encrypted parts
b8897ce 
Ticket: 6788
@msdean @lukashino
stream: decouple stream.bypass dependency from tls bypass
65504b3 
Decouple app.protocols.tls.encryption-handling and stream.bypass.
There's no apparent reason why encrypted TLS bypass traffic should
depend on stream bypass, as these are unrelated features.

Ticket: 6788
@lukashino
doc: remove trailing spaces in DPDK section
0aa01dd
@lukashino
ssh: sync the hassh setting with the defaults
541bd34
@github-actions GitHub Actions
Copy link

NOTE: This PR may contain new authors.

This was referenced Jan 13, 2025
Closed
Open
@lukashino
Copy link
Contributor Author

Continues in #12388

initially specified v5 version of SV tests

@lukashino lukashino closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catenacyber catenacyber Awaiting requested review from catenacyber catenacyber is a code owner

@jufajardini jufajardini Awaiting requested review from jufajardini jufajardini is a code owner

@victorjulien victorjulien Awaiting requested review from victorjulien victorjulien is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukashino @msdean