ldap: implement abandon request - v1 #12390
Closed
+44
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12390 +/- ##
==========================================
+ Coverage 80.63% 80.66% +0.02%
==========================================
Files 917 917
Lines 258687 258678 -9
==========================================
+ Hits 208601 208656 +55
+ Misses 50086 50022 -64
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
approved these changes
Jan 14, 2025
victorjulien
requested changes
Jan 14, 2025
so that we can implement abandon request support Ticket: OISF#7477
AkakiAlice
force-pushed
the
ldap-abandon-feature-7477-v1
branch
from
0d19946 to
edfe0cc
Compare
|
Rebased |
|
Please submit a new PR. |
5 tasks
|
Replaced by: #12396 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #7477
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7477
Describe changes:
SV_BRANCH=OISF/suricata-verify#2234