-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pyproject.toml #2413
Switch to pyproject.toml #2413
Conversation
Calling setup.py is marked obsolete for a long time and with this commit pyproject.toml is introduced and used for the development environment setup. On the packaging side the spec file is kept compatible with setup.py in a way that we try the build and installer python modules first and only if those are not present setup.py is called. For the publishing on pypi both targets wheel and sdist are used which is the default action of python -m build.
This PR is a followup from the conversation on #2376 |
If we want to start working on 10, maybe we should endeavor to close out the remaining stuff targeting master and branch that for kiwi-9 so master can be 10. If we do that, then I can just go ahead and make a pull request to convert the project to poetry and drastically reduce our host distro support. |
Problem here is that the master branch is used for publishing the docs, to pypi, for obs CI etc etc. All these systems would need to change their branch reference. I would like to avoid that because I'm sure mistakes will happen and they are painful. I thought we create a kiwi-10 branch (already done) and perform the changes we want over time. I'm confident that regular rebase of the kiwi-10 to master will not be painful. I can imagine some conversation on the topic so let's do that in the next community meeting |
Maybe we can use kiwi 10 as the point to switch to "main" then, since I'll be changing almost everything about how this project builds... |
That sounds like a nice idea |
@Conan-Kudo I'm closing this branch now as we agreed in the meeting and I assume you will tackle the move to poetry in #2370. Thanks much |
Calling
setup.py
is marked obsolete for a long time and with this commitpyproject.toml
is introduced and used for the development environment setup. On the packaging side the spec file is kept compatible with setup.py in a way that we try thebuild
andinstaller
python modules first and only if those are not present setup.py is called. For the publishing on pypi both targets wheel and sdist are used which is the default action ofpython -m build
.