-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: enhance Redis cluster testing with data assertion scripts #1209
Conversation
- Added new steps in the e2e test for Redis cluster to apply a data assertion tool, `data-assert`, for generating and validating data in the Redis cluster. - Replaced the previous Redis GET/SET checks with a more comprehensive data generation and validation process using the `data-assert` tool. - Introduced additional assertions to ensure data consistency after scaling operations. This update improves the reliability of e2e tests by ensuring data integrity in Redis clusters. Signed-off-by: drivebyer <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1209 +/- ##
==========================================
- Coverage 30.20% 29.78% -0.42%
==========================================
Files 55 57 +2
Lines 6294 6601 +307
==========================================
+ Hits 1901 1966 +65
- Misses 4200 4448 +248
+ Partials 193 187 -6 ☔ View full report in Codecov by Sentry. |
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | - | Generic CLI Secret | 10e8354 | tests/e2e-chainsaw/v1beta2/setup/redis-cluster/chainsaw-test.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
data-assert
, for generating and validating data in the Redis cluster.data-assert
tool.This update improves the reliability of e2e tests by ensuring data integrity in Redis clusters.
Description
Fixes #ISSUE
Type of change
Checklist
Additional Context