Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove strategy from test #795

Closed
wants to merge 1 commit into from

Conversation

shubham-cmyk
Copy link
Member

Description

Consider removing strategy from the CI since chainsaw can read the nested directory.

I am not sure we should do it or not it. We can consider this since it would less github runner.
we can make the test run in parallel that is done by default.

WDYT ?
@drivebyer

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.26%. Comparing base (d121d86) to head (7d020ba).
Report is 100 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #795      +/-   ##
==========================================
+ Coverage   35.20%   38.26%   +3.06%     
==========================================
  Files          19       19              
  Lines        3213     2645     -568     
==========================================
- Hits         1131     1012     -119     
+ Misses       2015     1565     -450     
- Partials       67       68       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shubham-cmyk
Copy link
Member Author

Test are failing.....

@drivebyer
Copy link
Collaborator

I believe it would be beneficial if Chainsaw could support the parallel execution of test cases. This way, we might be able to run all tests on a single runner.

@shubham-cmyk shubham-cmyk marked this pull request as draft March 31, 2024 17:19
@shubham-cmyk
Copy link
Member Author

@drivebyer chainsaw actually execute the test in the parallel.
we can control this

Signed-off-by: Shubham Gupta <[email protected]>
@drivebyer
Copy link
Collaborator

done by #1066

@drivebyer drivebyer closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants