Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: runtime panic when delete rediscluster which disable persistent #922

Merged
merged 1 commit into from
May 11, 2024
Merged

fix: runtime panic when delete rediscluster which disable persistent #922

merged 1 commit into from
May 11, 2024

Conversation

drivebyer
Copy link
Collaborator

Description

Fixes #921

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

@drivebyer drivebyer mentioned this pull request May 11, 2024
Closed
@drivebyer drivebyer added the bug Something isn't working label May 11, 2024
@codecov Codecov
Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.75%. Comparing base (d121d86) to head (833545b).
Report is 44 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #922      +/-   ##
==========================================
+ Coverage   35.20%   39.75%   +4.55%     
==========================================
  Files          19       19              
  Lines        3213     2674     -539     
==========================================
- Hits         1131     1063      -68     
+ Misses       2015     1540     -475     
- Partials       67       71       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer merged commit a9fa699 into OT-CONTAINER-KIT:master May 11, 2024
29 checks passed
@drivebyer drivebyer deleted the runtime-panic branch May 11, 2024 05:28
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
@drivebyer @mattrobinsonsre
fix: runtime panic when delete rediscluster which disable persistent (O…
0dca5b3 
…T-CONTAINER-KIT#922)

Signed-off-by: drivebyer <[email protected]>
Signed-off-by: Matt Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamabhishek-dubey iamabhishek-dubey Awaiting requested review from iamabhishek-dubey iamabhishek-dubey is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime panic error for the operator when a resource is created without storage
1 participant
@drivebyer