Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default port to enable SENTINEL_PORT environment #999

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

drivebyer
Copy link
Collaborator

Description

Fixes #995

When a user uses an old Redis image that does not have SENTINEL_PORT set as the default environment variable, we must configure SENTINEL_PORT to 26379 in the operator. Otherwise, the Sentinel probe will fail.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

@drivebyer drivebyer added the bug Something isn't working label Jun 19, 2024
@drivebyer drivebyer force-pushed the fix-sentinel-start branch from bda4247 to 6c8efc0 Compare June 19, 2024 09:59
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.85%. Comparing base (d121d86) to head (6c8efc0).
Report is 78 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #999       +/-   ##
===========================================
+ Coverage   35.20%   45.85%   +10.64%     
===========================================
  Files          19       20        +1     
  Lines        3213     2687      -526     
===========================================
+ Hits         1131     1232      +101     
+ Misses       2015     1380      -635     
- Partials       67       75        +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer merged commit c58d54f into OT-CONTAINER-KIT:master Jun 19, 2024
29 checks passed
@drivebyer drivebyer deleted the fix-sentinel-start branch June 19, 2024 12:58
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
…INER-KIT#999)

* fix: add default port to enable `SENTINEL_PORT` environment

Signed-off-by: drivebyer <[email protected]>

* fix test

Signed-off-by: drivebyer <[email protected]>

---------

Signed-off-by: drivebyer <[email protected]>
Signed-off-by: Matt Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redis Sentinel pods not starting after redis-operator upgrade
1 participant