feat: add bearer reader #59
Conversation
| } | ||
|
|
||
| private TestCaseResult parseBearerFindings(JSONObject result) { | ||
| /* |
There was a problem hiding this comment.
Is this code comment really necessary? You also provided a test file to look at.
There was a problem hiding this comment.
Thanks @darkspirit510
Yeah I removed it. Test case is more than enough :)
| * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR | ||
| * PURPOSE. See the GNU General Public License for more details. | ||
| * | ||
| * @author Sascha Knoop |
There was a problem hiding this comment.
No, I did not write this one 😉
There was a problem hiding this comment.
Thanks @darkspirit510
It's fixed now :)
|
@darkspirit510 - You OK with this MR now so I can merge it? |
|
@davewichers the code looks good, but as you wrote in OWASP-Benchmark/BenchmarkJava#214, I did not yet manage to create/test with a real file. |
|
@davewichers I just build the code from Bearer's repo and was able to scan the file. |
Hey @darkspirit510 thanks for this and sorry for the lack of response :( |
Add Bearer Reader
https://github.com/bearer/bearer
Requires this one to be released Bearer/bearer#1401