Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): hide invite button on mobile if disabled #8128

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

ulfgebhardt
Copy link
Member

🍰 Pullrequest

hide invite button on mobile if disabled

The invite button was displayed even when the functionality was dsiabled. This was caused by a missing check for the corresponding flag.

Issues

  • None

Todo

  • None

The invite button was displayed even when the functionality was
dsiabled. This was caused by a missing check for the corresponding flag.
@ulfgebhardt ulfgebhardt self-assigned this Dec 19, 2024
@ulfgebhardt ulfgebhardt requested a review from Tirokk December 19, 2024 00:15
Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool that you cared @ulfgebhardt

But there is a solution with a better design and layout.

webapp/components/HeaderMenu/HeaderMenu.vue Outdated Show resolved Hide resolved
- Remove the previously added 'div' tag.
Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed my suggestion with your authorization.

Now we can merge I guess.

@ulfgebhardt ulfgebhardt merged commit 1b67fc5 into master Jan 7, 2025
40 checks passed
@ulfgebhardt ulfgebhardt deleted the fix-hide-invite-on-mobile branch January 7, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants