Re-use current content fragment for loading related content #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinwale
reviewed
Oct 15, 2021
|
On FileView, tapping Back will bring user to the previous place, be it the Home or Following or Search. History stack is not kept. EDIT: everything else works as expected, including MiniPlayer. What this does is just reuse current fragment but loading new data. It is saving the time to recreate the fragment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number: #1
What is the current behavior?
Every related content click adds a transaction to the back stack, which means the browsing history is kept
What is the new behavior?
Related content is loaded in current fragment, which doesn't add the transaction to the back stack, not adding then to the browsing history