Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove USD references on UI #37

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Remove USD references on UI #37

merged 1 commit into from
Oct 22, 2021

Conversation

kekkyojin
Copy link
Collaborator

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Refactoring (no functional changes)
  • Documentation changes

Fixes

Issue Number: #1

What is the current behavior?

Conversion from Credits to USD is displayed on some parts of the UI

What is the new behavior?

Conversion to USD is no longer displayed

Other information

This PR keeps code to retrieve the LBC/USD rate, as it could still be used, for example to convert the claim cost from USD to LBC -the dynamic pricing style-.

This PR is also removing a View which was acting as a separator. a layout marginTop attribute is used instead. This simplifies the layout processing.

@kekkyojin kekkyojin requested a review from akinwale October 14, 2021 16:35
Copy link
Contributor

@akinwale akinwale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to have this eventually be a setting that the user can toggle at a later date, so instead of removing the controls and the conversion methods, let's just set them as hidden / gone for now.

Copy link
Contributor

@akinwale akinwale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kekkyojin kekkyojin merged commit ab416bd into master Oct 22, 2021
@kekkyojin kekkyojin deleted the remove-usd branch October 22, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants