Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auth_token to channel_sign request for creating comment #39

Merged
merged 2 commits into from
Oct 22, 2021

Conversation

kekkyojin
Copy link
Collaborator

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change

PR Type

What kind of change does this PR introduce?

  • Bugfix

Fixes

Issue Number: #1

What is the current behavior?

Authenticated user is not able to comment

What is the new behavior?

Authenticated user is able to comment

Other information

This is also fixing an app shutdown because of not signed in user cannot lists comments -as code is unable to see if user has liked or disliked any content-

@kekkyojin kekkyojin marked this pull request as ready for review October 19, 2021 17:02
@kekkyojin kekkyojin requested a review from akinwale October 19, 2021 17:02
Copy link
Contributor

@akinwale akinwale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kekkyojin kekkyojin merged commit da3731b into master Oct 22, 2021
@kekkyojin kekkyojin deleted the send_authtoken branch October 22, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants