Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refreshing faster user reaction UI status for content #42

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

kekkyojin
Copy link
Collaborator

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change

PR Type

What kind of change does this PR introduce?

  • Bugfix

Fixes

Issue Number: #1

What is the current behavior?

User reaction status to content is not updated until the scheduler is executed

What is the new behavior?

Reactions amount is updated accordingly on the UI

Other information

After a successful API call to react, the code to refresh the UI is called with an updated object. After that, the regular scheduled task is again created. This way, app refreshes the UI status before getting the remote data, but using the reaction request response as the reason to update the status. This makes it feel faster, as the UI is refreshed immediately without having to make a new request.

@kekkyojin kekkyojin requested a review from akinwale October 20, 2021 20:08
@kekkyojin kekkyojin changed the title Refresh faster user reaction UI status for content Refreshing faster user reaction UI status for content Oct 20, 2021
Copy link
Contributor

@akinwale akinwale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kekkyojin kekkyojin merged commit 2fb6cb6 into master Oct 22, 2021
@kekkyojin kekkyojin deleted the speeding-reaction branch October 22, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants