Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy green and night theme duplicate color resources #76

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

kekkyojin
Copy link
Collaborator

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Refactoring (no functional changes)

Fixes

Issue Number: #1

What is the current behavior?

There are some views which are using the LBRY Android green color

What is the new behavior?

Views are now using Odysee pink color

Other information

Duplicated colors for night theme has also been removed as Android will use default one.

Floating balance view has also been removed, as it is no longer been in use and it was using green color resource.

@kekkyojin kekkyojin requested a review from akinwale January 11, 2022 18:08
Copy link
Contributor

@akinwale akinwale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kekkyojin kekkyojin merged commit 5e2993b into master Jan 17, 2022
@kekkyojin kekkyojin deleted the ungreen-odysee branch January 17, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants