Feature/more reliable zookeeper #992
Open
+179
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 10, 2025 15:51
Rather than opening and closing connections for each Zookeeper interaction use the functionality in the KazooClient which maintains a connection with Zookeeper. This lowers resource consumption and improves latency.
KazooClient was mocked for some tests make sure this mocking is maintained with the new way of using KazooClient.
The IDE will get confused because the client will create methods at runtime. By referencing the KazooClient methods in the class the IDE can use hints based on the downstream methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will just create 1 KazooClient and keeps it running in the background. The KazooClient itself has logic to recover connectivity.
In order to deal with intermittent failure we also retry operations if they fail due to connectivity related issues. At this time the once that came from test scenario's were
kazoo.exceptions.SessionExpiredErrorandkazoo.exceptions.ConnectionLossbut if other retryable exceptions are identified they could be easily added.