Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental process namespace support #52

Merged
merged 6 commits into from
Aug 18, 2021
Merged

Experimental process namespace support #52

merged 6 commits into from
Aug 18, 2021

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Aug 5, 2021

Experimental process namespace support

Based on API PR Open-EO/openeo-api#348

@m-mohr m-mohr self-assigned this Aug 5, 2021
@m-mohr m-mohr changed the title Experimental namespace support Experimental process namespace support Aug 11, 2021
@m-mohr m-mohr mentioned this pull request Aug 11, 2021
Closed
@m-mohr m-mohr marked this pull request as draft August 11, 2021 13:57
@m-mohr m-mohr marked this pull request as ready for review August 12, 2021 09:52
@m-mohr m-mohr marked this pull request as draft August 12, 2021 10:02
@m-mohr m-mohr marked this pull request as ready for review August 12, 2021 12:56
christophfriedrich
christophfriedrich reviewed Aug 17, 2021
View reviewed changes
Copy link
Collaborator

@christophfriedrich christophfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only made it through the openeo.d.ts file yet but there are already a few comments so I already submit those now

openeo.d.ts Outdated Show resolved Hide resolved
openeo.d.ts Show resolved Hide resolved
openeo.d.ts Show resolved Hide resolved
openeo.d.ts Outdated Show resolved Hide resolved
openeo.d.ts Outdated Show resolved Hide resolved
christophfriedrich
christophfriedrich reviewed Aug 18, 2021
View reviewed changes
Copy link
Collaborator

@christophfriedrich christophfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finished looking through the rest of the files.

src/builder/builder.js Show resolved Hide resolved
src/builder/builder.js Show resolved Hide resolved
src/builder/formula.js Outdated Show resolved Hide resolved
src/builder/tapdigit.js Show resolved Hide resolved
src/connection.js Show resolved Hide resolved
src/connection.js Show resolved Hide resolved
src/connection.js Outdated Show resolved Hide resolved
src/openeo.js Outdated Show resolved Hide resolved
tests/vito.test.js Show resolved Hide resolved
@m-mohr @christophfriedrich
Fixes from code review
3a00ed7 
Co-authored-by: Christoph Friedrich <[email protected]>
@m-mohr m-mohr merged commit 3860cbb into development Aug 18, 2021
@m-mohr m-mohr deleted the ns-support branch August 18, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophfriedrich christophfriedrich christophfriedrich left review comments

Assignees

@m-mohr m-mohr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-mohr @christophfriedrich