Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination support #331 #332

Merged
merged 6 commits into from
Jan 5, 2025
Merged

Pagination support #331 #332

merged 6 commits into from
Jan 5, 2025

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Dec 6, 2024

Implements #331 and #233

Depends on:

Related PR:

Basic pagination support for jobs, services and files.

Following "issues" occur:

  • If you load more pages, the next automatic or manual refresh sets the whole list back to only show the first page. What I may have to do here to request the actual number of shown elements on refreshes, which means that that's the default page size from that time. Or I need to actually paginate and not just append, but then I need to save the URL for each page, too, so that I can refresh per page.
  • It seems like I have to press the "Load more..." button one additional time to remove it although no more results are present

@m-mohr m-mohr self-assigned this Dec 6, 2024
@m-mohr m-mohr linked an issue Dec 6, 2024 that may be closed by this pull request
@m-mohr m-mohr force-pushed the master branch 2 times, most recently from df55727 to 279c649 Compare January 2, 2025 16:12
@m-mohr m-mohr linked an issue Jan 4, 2025 that may be closed by this pull request
@m-mohr m-mohr marked this pull request as ready for review January 4, 2025 19:43
@m-mohr m-mohr requested review from soxofaan and jdries January 4, 2025 19:46
@m-mohr m-mohr merged commit 1711cda into master Jan 5, 2025
@m-mohr m-mohr deleted the pagination branch January 5, 2025 01:08
@m-mohr
Copy link
Member Author

m-mohr commented Jan 5, 2025

Is deployed now on editor.openeo.org for testing purposes (v0.14.0-rc.1).
If we don't find any obvious bugs, I'd release 0.14.0 in February or so...

@soxofaan
Copy link
Member

soxofaan commented Jan 6, 2025

Nice. Seems to work from some superficial testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request lists of resources with pagination Better indication that batch job is being started
2 participants