-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove -nointro for BioShock 2 Remastered and add all missing BioShock titles #173
Conversation
-nointro is no longer needed as the issue is fixed and both esync and fsync have to be disabled to prevent the texture issue
All BioShock 1 and 2 titles need esync and fsync disabled
All BioShock 1 and 2 titles need esync and fsync disabled
All BioShock 1 and 2 titles need esync and fsync disabled
We don't need to bother if esync and fsync are already handled by Proton, as Kisak's comment suggests. |
# to continue. That screen does not respond to keyboard or mouse, | ||
# so there is no way to continue. -nointro disables that screen | ||
# (but also the intro's at the start of the game). | ||
util.append_argument('-nointro') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm deciding that we should keep the fsync and esync related fixes for those titles while removing the disable intro argument until Kisak is able to substantiate their statement. I've already submitted a comment to them.
The -nointro fix can be removed as this has been addressed - ValveSoftware/Proton/issues/482
I have also tested this as working myself by allowing the intro videos to play then loading a game.
Added the 3 missing BioShock titles that all need Esync and Fsync disabled. This is for parity with Valve as they have disabled both of these for the titles as mentioned here.
They can be separated if needed but I've done them linked to BioShock 2 Remastered.