Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -nointro for BioShock 2 Remastered and add all missing BioShock titles #173

Merged
merged 7 commits into from
Dec 16, 2024

Conversation

kasha695
Copy link
Contributor

The -nointro fix can be removed as this has been addressed - ValveSoftware/Proton/issues/482

I have also tested this as working myself by allowing the intro videos to play then loading a game.

Added the 3 missing BioShock titles that all need Esync and Fsync disabled. This is for parity with Valve as they have disabled both of these for the titles as mentioned here.

They can be separated if needed but I've done them linked to BioShock 2 Remastered.

-nointro is no longer needed as the issue is fixed and both esync and fsync have to be disabled to prevent the texture issue
All BioShock 1 and 2 titles need esync and fsync disabled
All BioShock 1 and 2 titles need esync and fsync disabled
All BioShock 1 and 2 titles need esync and fsync disabled
@kasha695 kasha695 marked this pull request as draft December 15, 2024 20:05
@kasha695 kasha695 marked this pull request as ready for review December 15, 2024 20:11
@Root-Core
Copy link
Contributor

We don't need to bother if esync and fsync are already handled by Proton, as Kisak's comment suggests.

gamefixes-steam/409720.py Show resolved Hide resolved
# to continue. That screen does not respond to keyboard or mouse,
# so there is no way to continue. -nointro disables that screen
# (but also the intro's at the start of the game).
util.append_argument('-nointro')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm deciding that we should keep the fsync and esync related fixes for those titles while removing the disable intro argument until Kisak is able to substantiate their statement. I've already submitted a comment to them.

@R1kaB3rN R1kaB3rN marked this pull request as ready for review December 16, 2024 18:59
gamefixes-steam/409710.py Outdated Show resolved Hide resolved
@R1kaB3rN R1kaB3rN merged commit 97dd577 into Open-Wine-Components:master Dec 16, 2024
2 checks passed
@kasha695 kasha695 deleted the patch-1 branch December 16, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants