Modify the btcsuite address requirement to be coin agnostic #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So me, mg, and tyler talked about it. I think we're OK to remove the Params() function but at some point we do want to add in a function to return coin specific data as in #2. Additionally, the Params() function is currently being used in ob-go to generate HD keys, but we're thinking about changing the three interface functions that take in the HD keys to accept a new MasterKey object and have the wallet implementation be responsible for deriving the HD keys from that so the derivation does not happen in ob-go and it doesn't need to know about the key derivation data in I'll add to this PR with changes we're thinking about. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this change, a new interface 'WalletAddress' is introduced which contains the methods used by the app. The one method 'IsForNet' which is btc specific is excluded.