Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Src layout #508

Merged
merged 9 commits into from
Nov 12, 2024
Merged

Src layout #508

merged 9 commits into from
Nov 12, 2024

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Oct 14, 2024

Change the package layout to a src layout.
Closes #506

@coveralls
Copy link
Collaborator

coveralls commented Oct 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11805974223

Details

  • 25 of 26 (96.15%) changed or added relevant lines in 13 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 92.631%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/loader/flash/conftest.py 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
tests/test_config.py 2 98.35%
Totals Coverage Status
Change from base Build 11800778293: -0.06%
Covered Lines: 7555
Relevant Lines: 8156
💛 - Coveralls

@rettigl rettigl force-pushed the src_layout branch 2 times, most recently from 0574c1e to acfe9dc Compare October 15, 2024 14:40
@rettigl rettigl mentioned this pull request Oct 15, 2024
Closed
Base automatically changed from pydantic-model to v1_feature_branch October 22, 2024 17:14
@rettigl rettigl mentioned this pull request Oct 22, 2024
Closed
zain-sohail
zain-sohail approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@zain-sohail zain-sohail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Especially like the source code seperation completely.

@rettigl
Copy link
Member Author

rettigl commented Oct 25, 2024

This looks good. Especially like the source code seperation completely.

Great. I want to merge #474 and #510 first into main, and v1, and then rebase this here and fix everything remaining.

@rettigl rettigl merged commit 1b7b926 into v1_feature_branch Nov 12, 2024
5 checks passed
@rettigl rettigl deleted the src_layout branch November 12, 2024 21:32
@rettigl rettigl mentioned this pull request Nov 12, 2024
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zain-sohail zain-sohail zain-sohail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rettigl @coveralls @zain-sohail