Hextof lab loader #534
Open
Hextof lab loader #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zain-sohail
commented
Dec 19, 2024
| else: | ||
| raise ValueError(f"Unsupported core beamline: {core_beamline}") | ||
|
|
||
| def _validate_h5_files(self, config, h5_paths: list[Path]) -> list[Path]: |
There was a problem hiding this comment.
This validation was previously in BufferFilePaths and we had a discussion to move it from there. I find this location better (also was necessary due to restructure)
zain-sohail
commented
Dec 19, 2024
Comment on lines
-4
to
-7
| # TODO: move to config | ||
| MULTI_INDEX = ["trainId", "pulseId", "electronId"] | ||
| PULSE_ALIAS = MULTI_INDEX[1] | ||
| FORMATS = ["per_electron", "per_pulse", "per_train"] |
There was a problem hiding this comment.
these have now been moved to config/config model
zain-sohail
commented
Dec 19, 2024
| if PULSE_ALIAS in available_channels: | ||
| available_channels.remove(PULSE_ALIAS) | ||
| # Remove specified channels if they are present in available_channels. | ||
| channels_to_remove = ["pulseId", "numEvents"] |
There was a problem hiding this comment.
Currently hardcoded. A better suggestion welcomed.
zain-sohail
force-pushed
the
hextof-lab-loader
branch
from
c206130 to
788d189
Compare
Pull Request Test Coverage Report for Build 12811799296Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the lab loader requested in #503 . I tried to make minimal changes to the
FlashLoaderto make this work. The only major addition is the loader specific dataframe class and everything else stays approximately the same. So the lab data works with the flash loader but withbeamlineconfig ascfel.An example config is provided to make this work. Since I took out some hardcoded paramters (was in TODO) into the config, I updated the config model slightly.
Test data for this loading configuration still needs to be setup. I ask @kutnyakhov to provide a public file to perform this. Not sure if a tutorial is necessary or not.