Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add further exceptions for completely empty files, and exceptions #542

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Jan 7, 2025

handling for filesystems without proper file xattributes.
These are mostly relevant if the last file cannot be opened at all, and e.g. for S3 storage systems mounted with rclone

handling for filesystems without proper file xattributes
@rettigl rettigl requested a review from zain-sohail January 7, 2025 16:07
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12654883989

Details

  • 12 of 25 (48.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 92.037%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sed/loader/mirrorutil.py 2 4 50.0%
src/sed/loader/mpes/loader.py 10 21 47.62%
Totals Coverage Status
Change from base Build 12623184040: -0.1%
Covered Lines: 7571
Relevant Lines: 8226

💛 - Coveralls

Copy link
Member

@zain-sohail zain-sohail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the small comment.

src/sed/loader/mpes/loader.py Show resolved Hide resolved
@rettigl rettigl merged commit a99b945 into v1_feature_branch Jan 12, 2025
4 checks passed
@rettigl rettigl deleted the more-broken-file-fixes branch January 12, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants