-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mpes elab metadata #551
Open
rettigl
wants to merge
10
commits into
v1_feature_branch
Choose a base branch
from
mpes_elab_metadata
base: v1_feature_branch
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Mpes elab metadata #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rettigl
force-pushed
the
mpes_elab_metadata
branch
2 times, most recently
from
January 16, 2025 14:39
e08911f
to
8d969e0
Compare
Pull Request Test Coverage Report for Build 12876931909Details
💛 - Coveralls |
Hard for me to test this without any access. But I notice tests missing. Rather up to you if you'd like to include them or have done rough integration tests already. |
find .env files also in system config
rettigl
force-pushed
the
mpes_elab_metadata
branch
from
January 16, 2025 15:43
d84d0ea
to
ac18011
Compare
This is a draft so far. I will include tests eventually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds metadata retrieval from elabFTW at fhi.